In the last two articles on Spock I've covered mocking and stubbing. And I was pretty sold on Spock just based on that. But for a database driver, there's a killer feature: Data Driven Testing.
All developers have a tendency to think of and test the happy path. Not least of all because that's usually the path in the User Story - "As a customer I want to withdraw money and have the correct amount in my hand". We tend not to ask "what happens if they ask to withdraw money when the cash machine has no cash?" or "what happens when their account balance is zero?".
With any luck you'll have a test suite covering your happy paths, and probably at least twice as many grumpy paths. If you're like me, and you like one test to test one thing (and who doesn't?), sometimes your test classes can get quite long as you test various edge cases. Or, much worse (and I've done this too) you use a calculation remarkably like the one you're testing to generate test data. You run your test in a loop with the calculation and lo! The test passes. Woohoo?
Not that long ago I went through a process of re-writing a lot of unit tests that I had written a year or two before - we were about to do a big refactor of the code that generated some important numbers, and we wanted our tests to tell us we hadn't broken anything with the refactor. The only problem was, the tests used a calculation rather similar to the production calculation, and borrowed some constants to create the expected number. I ended up running the tests to find the numbers the test was generating as expected values, and hardcoding those values into the test. It felt dirty, but it was necessary - I wanted to make sure the refactoring didn't change the expected numbers as well as the ones generated by the real code. This is not a process I want to go through ever again.
When you're testing these sorts of things, you try and think of a few representative cases, code them into your tests, and hope that you've covered the main areas. What would be far nicer is if you could shove a whole load of different data into your system-under-test and make sure the results look sane.
An example from the Java driver is that we had tests that were checking the parsing of the URI - you can initialise your MongoDB settings simply using a String containing the URI.
The old tests looked like:
@Test()
public void testSingleServer() {
MongoClientURI u = new MongoClientURI("mongodb://db.example.com");
assertEquals(1, u.getHosts().size());
assertEquals("db.example.com", u.getHosts().get(0));
assertNull(u.getDatabase());
assertNull(u.getCollection());
assertNull( u.getUsername());
assertEquals(null, u.getPassword());
}
@Test()
public void testWithDatabase() {
MongoClientURI u = new MongoClientURI("mongodb://foo/bar");
assertEquals(1, u.getHosts().size());
assertEquals("foo", u.getHosts().get(0));
assertEquals("bar", u.getDatabase());
assertEquals(null, u.getCollection());
assertEquals(null, u.getUsername());
assertEquals(null, u.getPassword());
}
@Test()
public void testWithCollection() {
MongoClientURI u = new MongoClientURI("mongodb://localhost/test.my.coll");
assertEquals("test", u.getDatabase());
assertEquals("my.coll", u.getCollection());
}
@Test()
public void testBasic2() {
MongoClientURI u = new MongoClientURI("mongodb://foo/bar.goo");
assertEquals(1, u.getHosts().size());
assertEquals("foo", u.getHosts().get(0));
assertEquals("bar", u.getDatabase());
assertEquals("goo", u.getCollection());
}(view gist, and see the code in its original home: MongoClientURITest)
Using Spock's data driven testing, we changed this to:
@Unroll
def 'should parse #uri into correct components'() {
expect:
uri.getHosts().size() == num;
uri.getHosts() == hosts;
uri.getDatabase() == database;
uri.getCollection() == collection;
uri.getUsername() == username;
uri.getPassword() == password;
where:
uri | num | hosts | database | collection | username | password
new MongoClientURI('mongodb://db.example.com') | 1 | ['db.example.com'] | null | null | null | null
new MongoClientURI('mongodb://foo/bar') | 1 | ['foo'] | 'bar' | null | null | null
new MongoClientURI('mongodb://localhost/' +
'test.my.coll') | 1 | ['localhost'] | 'test' | 'my.coll' | null | null
new MongoClientURI('mongodb://foo/bar.goo') | 1 | ['foo'] | 'bar' | 'goo' | null | null
new MongoClientURI('mongodb://user:pass@' +
'host/bar') | 1 | ['host'] | 'bar' | null | 'user' | 'pass' as char[]
new MongoClientURI('mongodb://user:pass@' +
'host:27011/bar') | 1 | ['host:27012'] | 'bar' | null | 'user' | 'pass' as char[]
new MongoClientURI('mongodb://user:pass@' +
'host:7,' +
'host2:8,' +
'host3:9/bar') | 3 | ['host:7',
'host2:8',
'host3:9'] | 'bar' | null | 'user' | 'pass' as char[]
}
(view gist, and see the code in its original home: MongoClientURISpecification)
Instead of having a separate test for every type of URL that needs parsing, you have a single test and each line in the where: section is a new combination of input URL and expected outputs. Each one of those lines used to be a test. In fact, some of them probably weren't tests as the ugliness and overhead of adding another copy-paste test seemed like overkill. But here, in Spock, it's just a case of adding one more line with a new input and set of outputs.
The major benefit here, to me, is that it's dead easy to add another test for a "what if?" that occurs to the developer. You don't have to have yet another test method that someone else is going to wonder "what the hell are we testing this for?". You just add another line which documents another set of expected outputs given the new input.
It's easy, it's neat, it's succinct.
One of the major benefits of this to our team is that we don't argue any more about whether a single test is testing too much. In the past, we had tests like:
@Test
public void testGetLastErrorCommand() {
assertEquals(new BasicDBObject("getlasterror", 1), WriteConcern.UNACKNOWLEDGED.getCommand());
assertEquals(new BasicDBObject("getlasterror", 1), WriteConcern.ACKNOWLEDGED.getCommand());
assertEquals(new BasicDBObject("getlasterror", 1).append("w", 2), WriteConcern.REPLICA_ACKNOWLEDGED.getCommand());
assertEquals(new BasicDBObject("getlasterror", 1).append("j", true), WriteConcern.JOURNALED.getCommand());
assertEquals(new BasicDBObject("getlasterror", 1).append("fsync", true), WriteConcern.FSYNCED.getCommand());
assertEquals(new BasicDBObject("getlasterror", 1).append("w", "majority"), new WriteConcern("majority").getCommand());
assertEquals(new BasicDBObject("getlasterror", 1).append("wtimeout", 100), new WriteConcern(1, 100).getCommand());
}
And I can see why we have all those assertions in the same test, because technically these are all the same concept - make sure that each type of WriteConcern creates the correct command document. I believe these should be one test per line - because each line in the test is testing a different input and output, and I would want to document that in the test name ("fsync write concern should have fsync flag in getLastError command", "journalled write concern should set j flag to true in getLastError command" etc). Also don't forget that in JUnit, if the first assert fails, the rest of the test is not run. Therefore you have no idea if this is a failure that affects all write concerns, or just the first one. You lose the coverage provided by the later asserts.
But the argument against my viewpoint is then we'd have seven different one-line tests. What a waste of space.
You could argue for days about the best way to do it, or that this test is a sign of some other smell that needs addressing. But if you're in a real world project and your aim is to both improve your test coverage and improve the tests themselves, these arguments are getting in the way of progress. The nice thing about Spock is that you can take these tests that test too much, and turn them into something a bit prettier:
@Unroll
def '#wc should return getlasterror document #commandDocument'() {
expect:
wc.asDocument() == commandDocument;
where:
wc | commandDocument
WriteConcern.UNACKNOWLEDGED | ['getlasterror': 0]
WriteConcern.ACKNOWLEDGED | ['getlasterror': 1]
WriteConcern.REPLICA_ACKNOWLEDGED | ['getlasterror': 1, 'w': 2]
WriteConcern.JOURNALED | ['getlasterror': 1, 'j': true]
WriteConcern.FSYNCED | ['getlasterror': 1, 'fsync': true]
new WriteConcern('majority') | ['getlasterror': 1, 'w': 'majority']
new WriteConcern(1, 100) | ['getlasterror': 1, 'wtimeout': 100]
}You might be thinking, what's the advantage over the JUnit way? Isn't that the same thing but Groovier? But there's one important difference - all the lines under where: get run, regardless of whether the test before it passes or fails. This basically is seven different tests, but takes up the same space as one.
That's great, but if just one of these lines fails, how do you know which one it was if all seven tests are masquerading as one? That's where the awesome @Unroll annotation comes in. This reports the passing or failing of each line as if it were a separate test. By default, when you run an unrolled test it will get reported as something like:
But in the test above we put some magic keywords into the test name:
#wc should return getlasterror document #commandDocument - note that these values with # in front are the same headings from the where: section. They'll get replaced by the value being run in the current test:
Yeah, it can be a bit of a mouthful if the toString is hefty, but it does give you an idea of what was being tested, and it's prettier if the inputs have nice succinct string values:
This, combined with Spock's awesome power assert makes it dead simple to see what went wrong when one of these tests fails. Let's take the example of (somehow) the incorrect host being returned for one of the input URIs:
Data driven testing might lead one to over-test the simple things, but the cost of adding another "what if?" is so low - just another line - and the additional safety you get from trying a different input is rather nice. We've been using them for parsers and simple generators, where you want to throw in a bunch of inputs to a single method and see what you get out.
I'm totally sold on this feature, particularly for our type of application (the Java driver does a lot of taking stuff in one shape and turning it into something else). Just in case you want a final example, here's a final one.
The old way:
@Test
public void shouldGenerateIndexNameForSimpleKey() {
final Index index = new Index("x");
assertEquals("x_1", index.getName());
}
@Test
public void shouldGenerateIndexNameForKeyOrderedAscending() {
final Index index = new Index("x", OrderBy.ASC);
assertEquals("x_1", index.getName());
}
@Test
public void shouldGenerateIndexNameForKeyOrderedDescending() {
final Index index = new Index("x", OrderBy.DESC);
assertEquals("x_-1", index.getName());
}
@Test
public void shouldGenerateGeoIndexName() {
final Index index = new Index(new Index.GeoKey("x"));
assertEquals("x_2d", index.getName());
}
@Test
public void shouldCompoundIndexName() {
final Index index = new Index(new Index.OrderedKey("x", OrderBy.ASC),
new Index.OrderedKey("y", OrderBy.ASC),
new Index.OrderedKey("a", OrderBy.ASC));
assertEquals("x_1_y_1_a_1", index.getName());
}
@Test
public void shouldGenerateGeoAndSortedCompoundIndexName() {
final Index index = new Index(new Index.GeoKey("x"),
new Index.OrderedKey("y", OrderBy.DESC));
assertEquals("x_2d_y_-1", index.getName());
}...and in Spock:
@Unroll
def 'should generate index name #indexName for #index'() {
expect:
index.getName() == indexName;
where:
index | indexName
new Index('x') | 'x_1'
new Index('x', OrderBy.ASC) | 'x_1'
new Index('x', OrderBy.DESC) | 'x_-1'
new Index(new Index.GeoKey('x')) | 'x_2d'
new Index(new Index.OrderedKey('x', OrderBy.ASC),
new Index.OrderedKey('y', OrderBy.ASC),
new Index.OrderedKey('a', OrderBy.ASC)) | 'x_1_y_1_a_1'
new Index(new Index.GeoKey('x'),
new Index.OrderedKey('y', OrderBy.DESC)) | 'x_2d_y_-1'
}See also:
